Add locked_by and quit_by columns to live_results #13297
Conversation
|
Ok, I think the logic is correct now |
|
|
||
| scope :not_empty, -> { where.not(best: 0) } | ||
|
|
||
| scope :without_quitters, -> { where(quit_by_id: nil).or(where.not(best: 0)) } |
There was a problem hiding this comment.
In which case do you need the second or(where.not(best: 0)) part?
There was a problem hiding this comment.
Sidenote: .or(not_empty) should work
There was a problem hiding this comment.
We do still want to show quitters for previous rounds.
Currently when someone is quit from round 2 who advanced from round 1 I mark them as quit in round 2 and 1, but I still want to show them in round 1. There is a case to be made to only mark them as quit in round 1 as those results will already be locked so only flipping the advancing will be necessary?
| has_many :live_results_without_quitters, | ||
| -> { without_quitters.order(:global_pos) }, | ||
| class_name: "LiveResult" |
There was a problem hiding this comment.
Hm, it feels like this shouldn't be a separate relation. Why does some_round.live_results.without_quitters (ie, applying the without_quitters scope to the live_results relation) not work?
There was a problem hiding this comment.
because I use it in a scope one line down in the
has_many :live_competitors, through: :live_results_without_quitters, source: :registration
| init_round | ||
| return 0 if number == 1 || linked_round.present? |
There was a problem hiding this comment.
Why are you ignoring the return value of init_round? And what does the return value 0 represent?
There was a problem hiding this comment.
The return value is how many results where locked and it's 0 if there is no previous round to lock
|
|
||
| def open_and_lock_previous(current_user) | ||
| init_round | ||
| return 0 if number == 1 || linked_round.present? |
There was a problem hiding this comment.
Why are you returning early in case of a linked round? The linked round's individual rounds would all need to be locked, and returning early feels a bit premature...
There was a problem hiding this comment.
This is about locking the previous round as the title suggests. Linked Rounds do not have previous rounds
app/models/round.rb
Outdated
|
|
||
| result.mark_as_quit(current_user) | ||
|
|
||
| return 1 if number == 1 || linked_round.present? |
There was a problem hiding this comment.
What does this return value represent?
There was a problem hiding this comment.
how many results have been marked as quit
2 participants
I think this is a good comprise between a full table for locks and quits?